make it possible to use stage0 libtest on compiletest #139386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
from
15d164d to
7f3da8c
Compare
Kobzol
reviewed
Apr 4, 2025
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
from
7f3da8c to
8c17501
Compare
|
This PR modifies If appropriate, please update |
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
3 times, most recently
from
2ceaed5 to
48e9c4a
Compare
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
4 times, most recently
from
c757f55 to
c3cfdfc
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
from
c3cfdfc to
c830665
Compare
Kobzol
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Left one comment. The change otherwise looks fine. I'm not sure if we shouldn't do an MCP for this, but I think that libtest changed very rarely recently, so this shouldn't require a lot of cfg(bootstrap) places in compiletest. If it becomes a problem in the future, we can discuss it further.
In my opinion, the point we are discussing (whether compiletest should support stage0 with |
Kobzol
reviewed
Apr 7, 2025
Kobzol
reviewed
Apr 7, 2025
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
configurable-compiletest-libtest
branch
from
d2840fa to
cae28b5
Compare
|
I suppose that you can |
|
@bors r=jieyouxu,kobzol |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 8, 2025
…t-libtest, r=jieyouxu,kobzol make it possible to use stage0 libtest on compiletest With rust-lang#119899, building the library tree will require a stage 1 compiler. This is because `compiletest` is defined as a `ToolStd` (since rust-lang#68019) in order to use the in-tree library. As a result, rust-lang#119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompiling `compiletest` each time. This PR allows switching `ToolStd` to `ToolBootstrap` with a simple boolean option in `bootstrap.toml` to allow `compiletest` to use the stage 0 `libtest` instead. The changes under `src/ci` are clearly intended to make sure that `compiletest` doesn't break during future bootstrap beta bumps.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2025
…errors Rollup of 19 pull requests Successful merges: - rust-lang#138676 (Implement overflow for infinite implied lifetime bounds) - rust-lang#139024 (Make error message for missing fields with `..` and without `..` more consistent) - rust-lang#139098 (Tell LLVM about impossible niche tags) - rust-lang#139124 (compiler: report error when trait object type param reference self) - rust-lang#139321 (Update to new rinja version (askama)) - rust-lang#139346 (Don't construct preds w escaping bound vars in `diagnostic_hir_wf_check`) - rust-lang#139386 (make it possible to use stage0 libtest on compiletest) - rust-lang#139421 (Fix trait upcasting to dyn type with no principal when there are projections) - rust-lang#139468 (Don't call `Span::with_parent` on the good path in `has_stashed_diagnostic`) - rust-lang#139476 (rm `RegionInferenceContext::var_infos`) - rust-lang#139481 (Add job summary links to post-merge report) - rust-lang#139485 (compiletest: Stricter parsing for diagnostic kinds) - rust-lang#139490 (Update some comment/docs related to "extern intrinsic" removal) - rust-lang#139491 (Update books) - rust-lang#139496 (Revert r-a changes of rust-lang#139455) - rust-lang#139500 (document panic behavior of Vec::resize and Vec::resize_with) - rust-lang#139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types) - rust-lang#139504 (add missing word in doc comment) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#138676 (Implement overflow for infinite implied lifetime bounds) - rust-lang#139024 (Make error message for missing fields with `..` and without `..` more consistent) - rust-lang#139098 (Tell LLVM about impossible niche tags) - rust-lang#139124 (compiler: report error when trait object type param reference self) - rust-lang#139321 (Update to new rinja version (askama)) - rust-lang#139346 (Don't construct preds w escaping bound vars in `diagnostic_hir_wf_check`) - rust-lang#139386 (make it possible to use stage0 libtest on compiletest) - rust-lang#139421 (Fix trait upcasting to dyn type with no principal when there are projections) - rust-lang#139464 (Allow for reparsing failure when reparsing a pasted metavar.) - rust-lang#139490 (Update some comment/docs related to "extern intrinsic" removal) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2025
Rollup merge of rust-lang#139386 - onur-ozkan:configurable-compiletest-libtest, r=jieyouxu,kobzol make it possible to use stage0 libtest on compiletest With rust-lang#119899, building the library tree will require a stage 1 compiler. This is because `compiletest` is defined as a `ToolStd` (since rust-lang#68019) in order to use the in-tree library. As a result, rust-lang#119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompiling `compiletest` each time. This PR allows switching `ToolStd` to `ToolBootstrap` with a simple boolean option in `bootstrap.toml` to allow `compiletest` to use the stage 0 `libtest` instead. The changes under `src/ci` are clearly intended to make sure that `compiletest` doesn't break during future bootstrap beta bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #119899, building the library tree will require a stage 1 compiler. This is because
compiletestis defined as aToolStd(since #68019) in order to use the in-tree library. As a result, #119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompilingcompiletesteach time.This PR allows switching
ToolStdtoToolBootstrapwith a simple boolean option inbootstrap.tomlto allowcompiletestto use the stage 0libtestinstead.The changes under
src/ciare clearly intended to make sure thatcompiletestdoesn't break during future bootstrap beta bumps.